Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noted ability to specify multiple keys in bitswap unwant #2409

Merged
merged 1 commit into from
Feb 29, 2016

Conversation

RichardLitt
Copy link
Member

You can include an array of keys, not just a single key, but this isn't specified anywhere in the help text.

@RichardLitt RichardLitt added topic/docs-ipfs Topic docs-ipfs exp/novice Someone with a little familiarity can pick up need/review Needs a review labels Feb 26, 2016
@GitCop
Copy link

GitCop commented Feb 26, 2016

There were the following issues with your Pull Request

  • Commit: 7d8770e
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
@RichardLitt RichardLitt force-pushed the docs/bitswap-unwant-arg branch from 7d8770e to 8adf7a3 Compare February 26, 2016 17:09
@whyrusleeping
Copy link
Member

LGTM thanks!

whyrusleeping added a commit that referenced this pull request Feb 29, 2016
Noted ability to specify multiple keys in `bitswap unwant`
@whyrusleeping whyrusleeping merged commit 1d6e0d8 into master Feb 29, 2016
@whyrusleeping whyrusleeping deleted the docs/bitswap-unwant-arg branch February 29, 2016 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up need/review Needs a review topic/docs-ipfs Topic docs-ipfs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants